Re: [PATCH 0/2] Fix two regressions from start_creating()/start_removing() conversion
From: Amir Goldstein
Date: Wed Dec 24 2025 - 01:35:20 EST
On Tue, Dec 23, 2025 at 9:42 PM Tyler Hicks <code@xxxxxxxxxxx> wrote:
>
> When running the eCryptfs test suite on v6.19-rc2, I noticed BUG splats
> from every test and that the umount utility was segfaulting when tearing
> down after a test. Bisection led me to commit f046fbb4d81d ("ecryptfs:
> use new start_creating/start_removing APIs").
>
> This patch series addresses that regression and also a mknod problem
> spotted during code review.
>
Ouch!
Christian,
In retrospect, it's a shame that patches get merged with zero test coverage
and no ACK from the maintainer.
OTOH, relying on ACKs from all fs maintainers will seriously impair
the ability to make vfs wide changes like this one.
Feels like we need to find a better balance.
At least for ecryptfs, if we know that Tyler is at least testing rc1
regularly (?) that's a comfort.
Thanks,
Amir.