Re: [PATCH] perf symbol: remove Rust symbol workarounds

[Miguel Ojeda]

On Tue, Dec 23, 2025 at 6:54 PM Gary Guo <gary@xxxxxxxxxx> wrote:
>
> Drop the workaround in perf symbol that filter out these symbol types.
>
> Specifically, '1' and 'l' can never be generated by nm -- 'u' does
> indicate GNU unique, however such symbols are only generated by G++ for
> C++ templates, and are never generated by LLVM (LLVM generates weak
> symbols in such cases instead). Therefore, the previous occurrence of
> these symbols types must be due to the off-by-error and can be safely
> removed.

Thanks Gary, this indeed should go away now.

Should we mention `N` which is also removed? (i.e. you mention all the
others that got removed in the paragraph above).

In addition, should we remove the `__` prefix in the parameter name?
It was added in the commit that added `u`.

For context, the commits that added this were (probably useful to
mention in the commit message):

    945f50036169 ("perf symbols: Handle 'N' symbols in /proc/kallsyms")
    4d728bb93bab ("perf symbols: Handle 'u' and 'l' symbols in /proc/kallsyms")

With the notes above considered:

Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>

Cheers,
Miguel