Re: [PATCH v3] arm64: dts: qcom: monaco: add QCrypto node

From: Abhinaba Rakshit
Date: Wed Dec 24 2025 - 05:00:22 EST


On Wed, Dec 24, 2025 at 09:42:03AM +0100, Krzysztof Kozlowski wrote:
> On 24/12/2025 09:33, Abhinaba Rakshit wrote:
> > Add Qualcomm Crypto Engine device node for Monaco platform.
> >
> > QCE and Crypto DMA nodes patch was applied as part of
> > commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"),
> > however was partially reverted by commit cdc117c40537 ("arm64: dts: qcom:
> > qcs8300: Partially revert "arm64: dts: qcom: qcs8300: add QCrypto nodes"")
> > due to compatible string being mismatched against schema.
>
> ...due to Qualcomm engineer not ever bothering to build test the code.
>
> Was it build tested now? Typically this is implied by trusting people,
> but not here. Trust is lost.
>

Yes, the updated patch has now been build‑tested (including DT schema checks).
The previous issue happened due to an oversight on our end, and I agree that it should not have slipped through.
I’ll ensure future submissions are properly tested before sending them upstream.