Re: [PATCH v1 net-next 07/15] net/nebula-matrix: add vsi, queue, adminq resource definitions and implementation

From: Andrew Lunn
Date: Wed Dec 24 2025 - 05:49:23 EST


> +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/base/nbl_datapath.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: GPL-2.0*/
> +/*
> + * Copyright (c) 2025 Nebula Matrix Limited.
> + * Author:
> + */
> +// Code generated by interstellar. DO NOT EDIT.
> +// Compatible with leonis RTL tag 0710

That patch is way too big, it is unlikely anybody will review it for
you.

One thing which will help is put all the machine generated headers in
a separate patch. Make sure the commit message makes it clear this is
machine generated. Human reviewers will then only take a quick look,
but mostly ignore it. That helps make the real code which needs human
review stand out.

Andrew