[PATCH 2/3] hwmon: (max6639) Simplify with scoped for each OF child loop

From: Krzysztof Kozlowski
Date: Wed Dec 24 2025 - 06:08:03 EST


Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
---
drivers/hwmon/max6639.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/hwmon/max6639.c b/drivers/hwmon/max6639.c
index 99140a2ca995..a0a1dbbda887 100644
--- a/drivers/hwmon/max6639.c
+++ b/drivers/hwmon/max6639.c
@@ -563,7 +563,6 @@ static int max6639_init_client(struct i2c_client *client,
{
struct device *dev = &client->dev;
const struct device_node *np = dev->of_node;
- struct device_node *child;
int i, err;
u8 target_duty;

@@ -582,15 +581,13 @@ static int max6639_init_client(struct i2c_client *client,
data->target_rpm[0] = 4000;
data->target_rpm[1] = 4000;

- for_each_child_of_node(np, child) {
+ for_each_child_of_node_scoped(np, child) {
if (strcmp(child->name, "fan"))
continue;

err = max6639_probe_child_from_dt(client, child, data);
- if (err) {
- of_node_put(child);
+ if (err)
return err;
- }
}

for (i = 0; i < MAX6639_NUM_CHANNELS; i++) {
--
2.51.0