Re: [PATCH V2 3/5] mm/khugepaged: change collapse_pte_mapped_thp() to return void

From: Lance Yang
Date: Wed Dec 24 2025 - 07:22:34 EST




On 2025/12/24 19:13, Shivank Garg wrote:
The only external caller of collapse_pte_mapped_thp() is uprobe, which
ignores the return value. Change the external API to return void to
simplify the interface.

Introduce try_collapse_pte_mapped_thp() for internal use that preserves
the return value. This prepares for future patch that will convert
the return type to use enum scan_result.

Suggested-by: David Hildenbrand (Red Hat) <david@xxxxxxxxxx>
Signed-off-by: Shivank Garg <shivankg@xxxxxxx>
---

Looks good overall, thanks!

Acked-by: Lance Yang <lance.yang@xxxxxxxxx>