Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema

From: Alex Tran
Date: Wed Dec 24 2025 - 16:08:19 EST


> > + maxItems: 1
> > +
> > + reset-gpios:
> > + description:
> > + XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
> > + is in hardware standby mode when the signal is in the low state.
> > + maxItems: 1
> > +
> > + flash-leds:
> > + $ref: /schemas/media/video-interfaces.yaml#
>
> This and...
>
> > +
> > + lens-focus:
> > + $ref: /schemas/media/video-interfaces.yaml#
>
> ... this are weird. LEDs are not video interfaces, for sure. lens focus
> shouldn't be video interface, either.
>
> You also miss unevaluatedProps there.
>
> This needs careful fixing/rewriting, with explanation in commit msg.
>

My mistake. The correct schema reference for these 2 should be video
interface devices.

--
Yours,
Alex Tran