Re: [PATCH v3 12/13] rv: Add deadline monitors

[Nam Cao]

Nam Cao <namcao@xxxxxxxxxxxxx> writes:
> Gabriele Monaco <gmonaco@xxxxxxxxxx> writes:
>> Add the deadline monitors collection to validate the deadline scheduler,
>> both for deadline tasks and servers.
>>
>> The currently implemented monitors are:
>> * throttle:
>>     validate dl entities are throttled when they use up their runtime
>> * nomiss:
>>     validate dl entities run to completion before their deadiline
>>
>> Signed-off-by: Gabriele Monaco <gmonaco@xxxxxxxxxx>
>
> There are some helper functions that I am a bit uncomfortable with
> (e.g. pi_of, is_dl_boosted, dl_is_implicit, ...) because they are
> relying on implementation details of deadline scheduler which can be
> changed. So ideally this patch should have an Ack from the scheduler people.

Think about this again, perhaps we should move all these helpers to
include/linux/sched/deadline.h instead? The scheduler people must be
aware of these functions, and maintain them. I don't want a situation
where the scheduler people make changes, and something else (which they
do not know exist) breaks.

Ideally, non-scheduler code should not look at private fields of
scheduler's structs.

Nam