Re: [PATCH v2] netfilter: nft_counter: Fix reset of counters on 32bit archs

From: Florian Westphal
Date: Fri Dec 26 2025 - 16:29:24 EST


Anders Grahn <anders.grahn@xxxxxxxxx> wrote:
> nft_counter_reset() calls u64_stats_add() with a negative value to reset
> the counter. This will work on 64bit archs, hence the negative value
> added will wrap as a 64bit value which then can wrap the stat counter as
> well.
>
> On 32bit archs, the added negative value will wrap as a 32bit value and
> _not_ wrapping the stat counter properly. In most cases, this would just
> lead to a very large 32bit value being added to the stat counter.
>
> Fix by introducing u64_stats_sub().

Looks fine but:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Anders Grahn <anders.grahn@xxxxxxxxx>' != 'Signed-off-by: Anders Grahn <anders.grahn@xxxxxxxxxxxx>'