Re:Re: [PATCH v4 5/9] drm/bridge: add a driver for T-Head TH1520 HDMI controller

[Andy Yan]

Hello，

在 2025-12-26 21:27:53，"Icenowy Zheng" <zhengxingda@xxxxxxxxxxx> 写道：
>在 2025-12-25星期四的 19:07 +0800，Andy Yan写道：
>> 
>> 
>> Hello Icenowy:
>> 
>> At 2025-12-25 00:12:01, "Icenowy Zheng" <zhengxingda@xxxxxxxxxxx>
>> wrote:
>> > From: Icenowy Zheng <uwu@xxxxxxxxxx>
>> > 
>> > T-Head TH1520 SoC contains a Synopsys DesignWare HDMI controller
>> > (paired
>> > with DesignWare HDMI TX PHY Gen2) that takes the "DP" output from
>> > the
>> > display controller.
>> > 
>> > Add a driver for this controller utilizing the common DesignWare
>> > HDMI
>> > code in the kernel.
>> > 
>> > Signed-off-by: Icenowy Zheng <uwu@xxxxxxxxxx>
>> > Signed-off-by: Icenowy Zheng <zhengxingda@xxxxxxxxxxx>
>> > ---
>> > No changes in v3, v4.
>> > 
>> > Changes in v2:
>> > - Created a new function to set PHY parameters and refactored the
>> >  control flow of the configure_phy callback.
>> > 
>> > MAINTAINERS                             |   1 +
>> > drivers/gpu/drm/bridge/Kconfig          |  10 ++
>> > drivers/gpu/drm/bridge/Makefile         |   1 +
>> > drivers/gpu/drm/bridge/th1520-dw-hdmi.c | 173
>> > ++++++++++++++++++++++++
>> > 4 files changed, 185 insertions(+)
>> > create mode 100644 drivers/gpu/drm/bridge/th1520-dw-hdmi.c
>> 
>> 
>> As this is a Synopsys DesignWare based IP, maybe it's better to put
>> it under   "drivers/gpu/drm/bridge/synopsys/"
>> Or just create a dir for thead, I think there will come other display
>> related drivers for thead in the future.
>
>It's not proper to place vendor glues to synopsys/ .


TI has precedents for doing this with Cadence IP， see 

drivers/gpu/drm/bridge/cadence/cdns-dsi-j721e.c
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c 


>
>As for T-Head, they stopped their embedded SoC business (sold to
>another company) and now they only makes data-center chips, there
>should be no T-Head display drivers in the future.
>
>> 
>> 
>=========== 8< ============
>
>
>_______________________________________________
>linux-riscv mailing list
>linux-riscv@xxxxxxxxxxxxxxxxxxx
>http://lists.infradead.org/mailman/listinfo/linux-riscv