Re: [PATCH v2] rust: cpumask: rename methods of Cpumask for clarity and consistency

From: Kari Argillander
Date: Sat Dec 27 2025 - 09:49:31 EST


On Fri, 26 Dec 2025 at 18:08, Yilin Chen <1479826151@xxxxxx> wrote:
>
> Rename `as_ref` and `as_mut_ref` to `from_raw` and `from_raw_mut` to
> align with the established naming convention for constructing types
> from raw pointers in the kernel's Rust codebase.
>
> Signed-off-by: Yilin <1479826151@xxxxxx>

Alice already pointed out this in v1 of the patch [1]. You need real name here.
So this probably needs be "Yilin Chen <...>". This also needs to be fixed in
other patches you have sent to the list.

[1]: https://lore.kernel.org/rust-for-linux/aUMUA_JWalyGQdAx@xxxxxxxxxx/#t

> ---

This patch V2. Here after "---" you need to have changelog and usually it is
good idea to have link to old patch too. For new developers I personally suggest
to check b4 tool. That will make it easier to do new versions of patches.

Overall nice work and welcome to kernel Rust development.

Argillander