Re: [PATCH v7 2/4] misc: fastrpc: Rename phys to dma_addr for clarity

From: Dmitry Baryshkov
Date: Sat Dec 27 2025 - 12:15:46 EST


On Fri, Dec 26, 2025 at 12:35:32PM +0530, Kumari Pallavi wrote:
> The fields buf->phys and map->phys currently store DMA addresses
> returned by dma_map_*() APIs, not physical addresses. This naming
> is misleading and may lead to incorrect assumptions about the
> address type and its translation.
> Rename these fields from phys to dma_addr to improve code clarity
> and align with kernel conventions for dma_addr_t usage.
>
> Signed-off-by: Kumari Pallavi <kumari.pallavi@xxxxxxxxxxxxxxxx>
> ---
> drivers/misc/fastrpc.c | 77 ++++++++++++++++++++++--------------------

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>

> 1 file changed, 41 insertions(+), 36 deletions(-)