Re: [PATCH v3 3/5] pinctrl: samsung: add per-bank FLTCON offset to EXYNOS9_PIN_BANK_* and fix tables

[Krzysztof Kozlowski]

On 02/12/2025 10:36, Youngmin Nam wrote:
> Several Exynos9-era pin-bank tables were implicitly assuming that the
> filter control (FLTCON) registers are laid out contiguously from the
> EINT base offset. Per the TRMs this is not always true. FLTCON can live
> at a separate per-bank offset, and the current tables cause the driver
> to program the wrong FLTCON addresses for some banks.

"Can live" or "Does live"? Adding unused offset is not improving the
code. The implicit offset is fine, if it is correct.


Best regards,
Krzysztof