Re: [PATCH 1/2] iio: imu: lsm6dsx: Support SMOCF05 ACPI ID for LSM6DS3TR-C

From: Andy Shevchenko
Date: Sun Dec 28 2025 - 12:18:59 EST


On Mon, Dec 22, 2025 at 09:53:50PM -0500, Samuel Dionne-Riel wrote:
> Same device (LSM6DS3TR-C), different integration with the firmware.
>
> The integration differs in that the firmware provides the SLA0 and SLG0
> mounting matrices. They are assumed to be Accelerometer and Gyroscope.
>
> Observations were made against the Windows driver, version
> `12/06/2023,1.0.4.3`. This driver supports both identifiers, but expose
> the device in different ways.

...

> static const struct acpi_device_id st_lsm6dsx_i2c_acpi_match[] = {
> { "SMO8B30", ST_LSM6DS3TRC_ID, },
> + { "SMOCF05", ST_LSM6DS3TRC_ID, },

The trailing inner comma is redundant. Perhaps it would be nice to have
a cleanup patch to remove existing one.

> { }
> };

--
With Best Regards,
Andy Shevchenko