Re: [PATCH] vfio/pds: Fix memory leak in pds_vfio_dirty_enable()

[Alex Williamson]

On Thu, 25 Dec 2025 14:31:50 +0000
Zilin Guan <zilin@xxxxxxxxxx> wrote:

> pds_vfio_dirty_enable() allocates memory for region_info. If
> interval_tree_iter_first() returns NULL, the function returns -EINVAL
> immediately without freeing the allocated memory, causing a memory leak.
> 
> Fix this by jumping to the out_free_region_info label to ensure
> region_info is freed.
> 
> Fixes: 2e7c6feb4ef52 ("vfio/pds: Add multi-region support")
> Signed-off-by: Zilin Guan <zilin@xxxxxxxxxx>
> ---
>  drivers/vfio/pci/pds/dirty.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vfio/pci/pds/dirty.c b/drivers/vfio/pci/pds/dirty.c
> index 481992142f79..4915a7c1c491 100644
> --- a/drivers/vfio/pci/pds/dirty.c
> +++ b/drivers/vfio/pci/pds/dirty.c
> @@ -292,8 +292,11 @@ static int pds_vfio_dirty_enable(struct pds_vfio_pci_device *pds_vfio,
>  	len = num_ranges * sizeof(*region_info);
>  
>  	node = interval_tree_iter_first(ranges, 0, ULONG_MAX);
> -	if (!node)
> -		return -EINVAL;
> +	if (!node) {
> +		err = -EINVAL;
> +		goto out_free_region_info;
> +	}
> +
>  	for (int i = 0; i < num_ranges; i++) {
>  		struct pds_lm_dirty_region_info *ri = &region_info[i];
>  		u64 region_size = node->last - node->start + 1;

Applied to vfio for-linus branch for v6.19.  Thanks,

Alex