Re: [PATCH] drm: pl111: fix build regression

[Eslam Khafagy]

On 12/23/25 23:49, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The drm_info() function requires the drm/drm_print.h header to be included
> first:
>
> In file included from drivers/gpu/drm/pl111/pl111_nomadik.c:7:
> drivers/gpu/drm/pl111/pl111_nomadik.h:11:32: error: 'struct drm_device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>     11 | void pl111_nomadik_init(struct drm_device *dev);
>        |                                ^~~~~~~~~~
> drivers/gpu/drm/pl111/pl111_nomadik.c: In function 'pl111_nomadik_init':
> drivers/gpu/drm/pl111/pl111_nomadik.c:34:9: error: implicit declaration of function 'drm_info'; did you mean 'pr_info'? [-Wimplicit-function-declaration]
>     34 |         drm_info(dev, "set Nomadik PMU mux to CLCD mode\n");
>        |         ^~~~~~~~
>        |         pr_info
>
> Fixes: a1542b8ca6ed ("drm: pl111: replace dev_* print functions with drm_* variants")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>   drivers/gpu/drm/pl111/pl111_nomadik.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_nomadik.c b/drivers/gpu/drm/pl111/pl111_nomadik.c
> index f3218d59c5f1..0e5153deb1ac 100644
> --- a/drivers/gpu/drm/pl111/pl111_nomadik.c
> +++ b/drivers/gpu/drm/pl111/pl111_nomadik.c
> @@ -4,6 +4,7 @@
>   #include <linux/mfd/syscon.h>
>   #include <linux/bitops.h>
>   #include <linux/module.h>
> +#include <drm/drm_print.h>
>   #include "pl111_nomadik.h"
>   
>   #define PMU_CTRL_OFFSET 0x0000
Thank you Arnd for catching this . It's my bad missed to compile with 
CONFIG_ARCH_NOMADIK config.

Reviewed-by: Eslam Khafagy <eslam.medhat1993@xxxxxxxxx>