Re: [PATCH V1 2/4] scsi: ufs: qcom: dt-bindings: Add UFSHC compatible for Hamoa

From: Rob Herring (Arm)

Date: Mon Dec 29 2025 - 02:38:07 EST



On Mon, 29 Dec 2025 11:36:40 +0530, Pradeep P V K wrote:
> Document the UFSHC compatible for Qualcomm Hamoa SoC. Use fallback
> to indicate the compatibility of UFSHC on Hamoa with that on the
> SM8550.
>
> Signed-off-by: Pradeep P V K <pradeep.pragallapati@xxxxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.example.dtb: ufs@1d84000 (qcom,sm8450-ufshc): compatible: 'oneOf' conditional failed, one must be fixed:
['qcom,sm8450-ufshc', 'qcom,ufshc', 'jedec,ufs-2.0'] is too long
'qcom,sm8450-ufshc' is not one of ['qcom,hamoa-ufshc']
'qcom,ufshc' was expected
'jedec,ufs-2.0' was expected
'qcom,sm8550-ufshc' was expected
from schema $id: http://devicetree.org/schemas/ufs/qcom,sc7180-ufshc.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20251229060642.2807165-3-pradeep.pragallapati@xxxxxxxxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.