Re: [PATCH V1 2/3] dt-bindings: power: sbs-battery: add polling interval property

[Krzysztof Kozlowski]

On 29/12/2025 09:56, LI Qingwu wrote:
> Add the optional sbs,monitoring-interval-ms property for SBS-compliant
> batteries to configure a periodic polling interval on systems without
> interrupt support. The driver periodically checks the battery status and
> notifies userspace of changes when this property is set, and ignores it
> when a GPIO interrupt is available.
> 
> The property defaults to 0 to preserve existing behaviour.
> 
> Signed-off-by: LI Qingwu <Qing-wu.Li@xxxxxxxxxxxxxxxxxxxxxxx>
> ---
>  .../bindings/power/supply/sbs,sbs-battery.yaml           | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/sbs,sbs-battery.yaml b/Documentation/devicetree/bindings/power/supply/sbs,sbs-battery.yaml
> index 90b9d3d882a4..fbdd5dd5dda8 100644
> --- a/Documentation/devicetree/bindings/power/supply/sbs,sbs-battery.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/sbs,sbs-battery.yaml
> @@ -59,6 +59,15 @@ properties:
>        master implementation.
>      type: boolean
>  
> +  sbs,monitoring-interval-ms:
> +    description:
> +      Polling interval in milliseconds for battery status monitoring on
> +      systems without interrupt support. The driver periodically checks
> +      the battery status and notifies userspace of changes. Ignored when
> +      GPIO interrupt is available.


You described the desired Linux feature or behavior, not the actual
hardware. The bindings are about the latter, so instead you need to
rephrase the property and its description to match actual hardware
capabilities/features/configuration etc.


Best regards,
Krzysztof