Re: [PATCH v1 2/2] dt-bindings: net: micrel: Convert micrel-ksz90x1.txt to DT schema

From: Stefan Eichenberger
Date: Mon Dec 29 2025 - 04:40:14 EST


On Tue, Dec 23, 2025 at 03:39:24PM +0100, Andrew Lunn wrote:
> > + patternProperties:
> > + '^([rt]xd[0-3]|[rt]xc|rxdv|txen)-skew-ps$':
> > + description: |
> > + Skew control of the pad in picoseconds. A value of 0 equals to a
> > + skew of -840ps.
> > + The actual increment on the chip is 120ps ranging from -840ps to
> > + 960ps, this mismatch comes from a documentation error before
> > + datasheet revision 1.2 (Feb 2014):
>
> > - Device Tree Value Delay Pad Skew Register Value
> > - -----------------------------------------------------
> > - 0 -840ps 0000
> > - 200 -720ps 0001
> > - 400 -600ps 0010
> > - 600 -480ps 0011
> > - 800 -360ps 0100
> > - 1000 -240ps 0101
> > - 1200 -120ps 0110
> > - 1400 0ps 0111
> > - 1600 120ps 1000
> > - 1800 240ps 1001
> > - 2000 360ps 1010
> > - 2200 480ps 1011
> > - 2400 600ps 1100
> > - 2600 720ps 1101
> > - 2800 840ps 1110
> > - 3000 960ps 1111
>
> I think this table is more readable? But maybe without the register
> value, which is an implementation detail.

Thanks, you are right. I will add a table again in the next version and
drop the register values as suggested.

Regards,
Stefan