Re: [PATCH V1 2/4] scsi: ufs: qcom: dt-bindings: Add UFSHC compatible for Hamoa
From: Krzysztof Kozlowski
Date: Mon Dec 29 2025 - 07:21:14 EST
On 29/12/2025 08:13, Krzysztof Kozlowski wrote:
> On 29/12/2025 07:06, Pradeep P V K wrote:
>> Document the UFSHC compatible for Qualcomm Hamoa SoC. Use fallback
>> to indicate the compatibility of UFSHC on Hamoa with that on the
>> SM8550.
>
> Same problem.
>
>>
>> Signed-off-by: Pradeep P V K <pradeep.pragallapati@xxxxxxxxxxxxxxxx>
>> ---
>> .../devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
>> index d94ef4e6b85a..3b5a95db7831 100644
>> --- a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
>
> That's older devices binding. Why would Hamoa fit here?
... and why even bothering with testing this? Every internal guide tells
you this yet you sent it untested.
Best regards,
Krzysztof