Re: [PATCH v2 2/2] arm64: dts: qcom: kaanapali: Add TSENS and QUPv3 serial engines

[Konrad Dybcio]

On 12/26/25 4:06 AM, Jingyi Wang wrote:
> Add new features on the Kaanapali Platform including:
> 
> - Temperature Sensor (TSENS) and thermal zones
> - QUPv3 serial engine protocols with 5 I2C hubs and 24 QUP serial engines
>   across 4 QUP wrappers, each with support of GPI DMA engines.
> 
> Co-developed-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
> Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
> Co-developed-by: Jyothi Kumar Seerapu <jyothi.seerapu@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jyothi Kumar Seerapu <jyothi.seerapu@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jingyi Wang <jingyi.wang@xxxxxxxxxxxxxxxx>
> ---

Since the base DT is now merged, all subsequent patches are
supposed to be patch-sized, i.e. usually scoped for one feature that
makes sense. This one happens to be an arbitrary concatenation of two
separate ones. Were they separate, the original authors would benefit
from the full attribution and they would be easier for us to review

Konrad