Re: [PATCH v2] bus: fsl-mc: fix an error handling in fsl_mc_device_add()

From: Markus Elfring
Date: Mon Dec 29 2025 - 09:37:09 EST


> If device_add() fails, call put_device() to drop the device
> reference.

Can the word wrapping become nicer?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc3#n659


> And put_device() triggers fsl_mc_device_release()
> which does the free. Thus just return after call put_device().

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc3#n145

Regards,
Markus