Re: [PATCH v3 13/14] ntfs: add Kconfig and Makefile

From: Matthew Wilcox
Date: Mon Dec 29 2025 - 11:42:10 EST


On Mon, Dec 29, 2025 at 07:59:31PM +0900, Namjae Jeon wrote:
> +++ b/fs/ntfs/Makefile
> @@ -0,0 +1,18 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Makefile for the ntfs filesystem support.
> +#
> +
> +# to check robot warnings

What does this comment mean? I see ntfs3 also has this, so was this a
case of blindly copying?

> +ccflags-y += -Wint-to-pointer-cast \
> + $(call cc-option,-Wunused-but-set-variable,-Wunused-const-variable) \
> + $(call cc-option,-Wold-style-declaration,-Wout-of-line-declaration)

-Wint-to-pointer-cast is already enabled by default,
-Wunused-but-set-variable is enabled by -Wall, so both of these can be
dropped I think.