Re: [PATCH v4 3/3] rtc: spacemit: default module when MFD_SPACEMIT_P1 is enabled

[Alex Elder]

On 12/25/25 10:53 AM, Alexandre Belloni wrote:
> On 25/12/2025 15:46:33+0800, Troy Mitchell wrote:
> > The RTC driver defaulted to the same value as MFD_SPACEMIT_P1, which
> > caused it to be built-in automatically whenever the PMIC support was
> > set to y.
> >
> > This is not always desirable, as the RTC function is not required on
> > all platforms using the SpacemiT P1 PMIC.
>
> But then, can't people simply change the config? I don't feel like
> this is an improvement.

It's not an improvement for people who want to use the SpacemiT
P1 PMIC, but it's an improvement for all the other RISC-V builds
using "defconfig" that would rather have that support be modular
to avoid needlessly consuming resources.

I haven't done any testing on this but it looks fine to me.

Acked-by: Alex Elder <elder@xxxxxxxxxxxx>

I think it's a small change worth merging.  I don't think
doing so does any harm.  Your call or course, Alexandre.

					-Alex

> > Signed-off-by: Troy Mitchell <troy.mitchell@xxxxxxxxxxxxxxxxxx>
> > ---
> >   drivers/rtc/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> > index 50dc779f7f983074df7882200c90f0df21d142f2..53866493e9bbaf35ff0de85cbfe43e8343eadc1e 100644
> > --- a/drivers/rtc/Kconfig
> > +++ b/drivers/rtc/Kconfig
> > @@ -410,7 +410,7 @@ config RTC_DRV_SPACEMIT_P1
> >   	tristate "SpacemiT P1 RTC"
> >   	depends on ARCH_SPACEMIT || COMPILE_TEST
> >   	depends on MFD_SPACEMIT_P1
> > -	default MFD_SPACEMIT_P1
> > +	default m if MFD_SPACEMIT_P1
> >   	help
> >   	  Enable support for the RTC function in the SpacemiT P1 PMIC.
> >   	  This driver can also be built as a module, which will be called
> >
> > --
> > 2.52.0