Re: [PATCH v5 1/2] dt-bindings: hwmon: add STEF48H28
From: Yungteng Hsu
Date: Mon Dec 29 2025 - 19:47:03 EST
Guenter Roeck <linux@xxxxxxxxxxxx> 於 2025年12月30日週二 上午5:05寫道:
>
> On Mon, Dec 29, 2025 at 06:39:55PM +0800, Charles Hsu wrote:
> > Add device tree bindings for the hot-swap controller STEF48H28.
> >
> > Changes in v5:
> > - Move the change list into the commit message.
> >
> > Changes in v4:
> > - Fix an incorrect datasheet URL and update it to the correct reference.
> >
> > Changes in v3:
> > - Move the STEF48H28 Device Tree binding from
> > trivial-devices.yaml to pmbus/stef48h28.yaml.
> >
> > Changes in v2:
> > - Fix the entry in trivial-devices.yaml by correcting the comment
> > and compatible string ordering.
> >
> > Signed-off-by: Charles Hsu <hsu.yungteng@xxxxxxxxx>
> > ---
>
> First there are no change logs, than this ... change log goes here,
> after "---".
>
> Nowadays it seems that 80+ % of my time is taken up with such
> trivialities, distracting from the actual code reviews.
>
> I really need to set up AI code reviews to handle that :-(.
>
> Guenter
>
Sorry about this. I’m still getting familiar with the expected
changelog conventions.
For the next step, should I put the changelog below the --- and resend
the patch?
Charles