Re: [PATCH v3] mmc: host: sdhci-msm: Add support for wrapped keys

[Neeraj Soni]

Hi,

On 12/29/2025 6:48 PM, Konrad Dybcio wrote:
> On 12/29/25 8:05 AM, Neeraj Soni wrote:
>> Add the wrapped key support for sdhci-msm by implementing the needed
>> methods in struct blk_crypto_ll_ops and setting the appropriate flag in
>> blk_crypto_profile::key_types_supported.
>>
>> Tested on SC7280 eMMC variant.
> 
> [...]
> 
>> +static int sdhci_msm_ice_derive_sw_secret(struct blk_crypto_profile *profile,
>> +					  const u8 *eph_key, size_t eph_key_size,
>> +					  u8 sw_secret[BLK_CRYPTO_SW_SECRET_SIZE])
> 
> These should be aligned, please touch that up
Thanks for pointing out. Will fix it in next patch.
> 
>> +{
>> +	struct sdhci_msm_host *msm_host =
>> +		sdhci_msm_host_from_crypto_profile(profile);
> 
> Please feel free to unwrap this line (and its copies)
Sure.
>> +
>> +	return qcom_ice_derive_sw_secret(msm_host->ice, eph_key, eph_key_size,
>> +					sw_secret);
> 
> And this one too
Okay will fix this too in next patch.
> 
> Logic-wise, I don't see anything obviously wrong> 
> Konrad
> 
Regards
Neeraj