Re: [PATCH v2 1/6] staging: iio: ad9832: cleanup dev_err_probe()
From: Jonathan Cameron
Date: Wed Dec 31 2025 - 13:02:48 EST
On Wed, 31 Dec 2025 00:47:43 +0200
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> On Tue, Dec 30, 2025 at 10:35 PM Tomas Borquez <tomasborquez13@xxxxxxxxx> wrote:
> >
> > Cleanup dev_err_probe() by keeping messages consistent and adding
> > error message for clock acquisition failure.
>
> AFAICS this does two things, the second one is reuse of the temporary
> variable for struct device.
>
Agreed. Ideal patch break up would be to not just mention
them but do the struct device *dev first, then the dev_err_probe()
change.