Re: [PATCH v2 2/6] staging: iio: ad9832: convert to guard(mutex)
From: Tomas Borquez
Date: Wed Dec 31 2025 - 12:01:59 EST
On Wed, Dec 31, 2025 at 12:50:54AM +0200, Andy Shevchenko wrote:
> On Tue, Dec 30, 2025 at 10:35 PM Tomas Borquez <tomasborquez13@xxxxxxxxx> wrote:
> >
> > Use guard(mutex) for cleaner lock handling and simpler error paths.
>
> ...
>
> Don't remember if it was in the previous rounds of review or somewhere
> else, but Jonathan (? IIRC) suggestd to use
>
> ret = foo(...);
> if (ret)
> return ret;
> break;
> ...
> return len;
You are right, I should have sticked to that one since anyways I ended
up using that pattern on patch 5.
> However, this one just duplicates what is already in use. Have you
> checked the bloat-o-meter before and after and see if there is any
> difference in the compiled object file?
Jonathan's is better by 7 delta, so I'll stick with his
> --
> With Best Regards,
> Andy Shevchenko