Re: [PATCH v4] rust: Add support for feeding entropy to randomness pool
From: Miguel Ojeda
Date: Wed Dec 31 2025 - 10:46:27 EST
On Wed, Dec 31, 2025 at 1:48 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
>
> Thanks for CCing me Miguel. I find it strange that it was left out on
> apparently 4 revisions of it. Yes, this should be added to the
> MAINTAINER's normal rng section. I'm happy to maintain this.
You're welcome, and thanks for the quick reply!
> Bigger question, perhaps for Miguel: what's the convention for adding
> these bindings? Is it, (A) "this is a useful API surface, so let's add the
> functions so driver writers can use them later" or is it (B) "add useful
> APIs as they're needed by driver writers"?
We follow the usual kernel practice, so (B), though sometimes a user
is known to be incoming, so it gets added in a separate series for
convenience or similar.
But, yeah, in such a case, it should be agreed upon / explained where
it is supposed to be used, and the cover letter here should do that
(and you are completely right to ask!).
Cheers,
Miguel