Re: [PATCH] scsi: hpsa: Fix memory leak in hpsa_undo_allocations_after_kdump_soft_reset()

[Zilin Guan]

On Tue, Dec 30, 2025 at 01:09:14PM +0100, Markus Elfring wrote:
> …
> > +++ b/drivers/scsi/hpsa.c
> > @@ -8212,6 +8212,8 @@ static void hpsa_undo_allocations_after_kdump_soft_reset(struct ctlr_info *h)
> >  		h->monitor_ctlr_wq = NULL;
> >  	}
> >  
> > +	kfree(h->reply_map);		/* init_one 1 */
> > +	h->reply_map = NULL;		/* init_one 1 */
> 
> I find this reset statement redundant here.
> 
> 
> >  	kfree(h);				/* init_one 1 */
> >  }
> 
> 
> Regards,
> Markus

Hi Markus,

Thanks for the review.

I originally added the NULL assignment to maintain consistency with the 
existing code style in this function, but I agree it is redundant here.

I will remove it in v2.

Best regards,
Zilin Guan