Re: [PATCH v2 2/2] staging: media: tegra-video: move tegra20_vip_soc declaration to vip.h

From: Luca Ceresoli

Date: Wed Dec 31 2025 - 09:01:54 EST


On Wed Dec 31, 2025 at 1:39 PM CET, Sun Jian wrote:
> tegra20_vip_soc is shared across translation units but is currently
> declared via an extern in vip.c. Move the declaration to vip.h so users get
> it via the header and we avoid extern declarations in .c files, matching
> the pattern already used by tegra20_vi_soc and tegra210_vi_soc.
>
> Link: https://lore.kernel.org/linux-staging/DFCAOR6T9DPE.2MOL0K9O3HP1N@xxxxxxxxxxx/T/
> Suggested-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
> Signed-off-by: Sun Jian <sun.jian.kdev@xxxxxxxxx>

Tested-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> # build tested
Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com