Re: [PATCH 0/3] arm64: dts: rockchip: Enable the NPU on some rk3588 boards
From: Ricardo Pardini
Date: Wed Dec 31 2025 - 05:48:01 EST
Hi Jimmy,
This series enables the NPU on a few Rockchip rk3588 boards.
In every case here, the required regulator was already described.
Now that the pd_npu has defined the dependency to the vdd_npu_s0,Nice, I overlooked that. I'll send a v2 removing `regulator-always-on;` from the regulator.
shouldn't the regulator-always-on be removed from the regulator? When
the Rock5B enabled the NPU, it didn't define the regulator with always
on. [1]
More specifically, the commit message for the introduction of the
pd_npu label mentions how the regulator no longer needs to be always
on. [2]
[1] https://lore.kernel.org/linux-rockchip/20250721-6-10-rocket-v9-10-77ebd484941e@xxxxxxxxxxxxxxx/
[2] https://lore.kernel.org/linux-rockchip/20250721-6-10-rocket-v9-7-77ebd484941e@xxxxxxxxxxxxxxx/
And maybe a separate series removing it from the the other NPU-enabled boards that still have it?
Thanks,
Ricardo