Re: [PATCH v4 7/7] ARM: dts: rockchip: rk3506: Add pinctrl and rmio dtsi for rk3506

[Ye Zhang]

在 2025/12/28 18:37, Krzysztof Kozlowski 写道:
> On 27/12/2025 12:49, Ye Zhang wrote:
> > +		/omit-if-no-ref/
> > +		rm_io28_touch_key_in6: rm-io28-touch-key-in6 {
> > +			rockchip,pins =
> > +				<1 RK_PC3 7 &pcfg_pull_none>;
> > +			rockchip,rmio-pins =
> > +				<0 28 49>;
> > +		};
> > +
> > +		/omit-if-no-ref/
> > +		rm_io28_touch_key_in7: rm-io28-touch-key-in7 {
> > +			rockchip,pins =
> > +				<1 RK_PC3 7 &pcfg_pull_none>;
> > +			rockchip,rmio-pins =
> > +				<0 28 50>;
> > +		};
> > +
> > +		/omit-if-no-ref/
> > +		rm_io28_sai0_mclk: rm-io28-sai0-mclk {
> > +			rockchip,pins =
> > +				<1 RK_PC3 7 &pcfg_pull_none>;
> > +			rockchip,rmio-pins =
> > +				<0 28 51>;
> > +		};
> > +
> > +		/omit-if-no-ref/
> > +		rm_io28_sai0_sclk: rm-io28-sai0-sclk {
> > +			rockchip,pins =
> > +				<1 RK_PC3 7 &pcfg_pull_none>;
> > +			rockchip,rmio-pins =
> > +				<0 28 52>;
> > +		};
> > +
> > +		/omit-if-no-ref/
> > +		rm_io28_sai0_lrck: rm-io28-sai0-lrck {
> > +			rockchip,pins =
> > +				<1 RK_PC3 7 &pcfg_pull_none>;
> > +			rockchip,rmio-pins =
> > +				<0 28 53>;
> > +		};
> > +
> > +		/omit-if-no-ref/
> > +		rm_io28_sai0_sdi0: rm-io28-sai0-sdi0 {
> > +			rockchip,pins =
> > +				<1 RK_PC3 7 &pcfg_pull_none>;
> > +			rockchip,rmio-pins =
> > +				<0 28 54>;
> > +		};
> Why are you defining all pins? This is wrong, your driver has to do it,
> not DTS. All these definitions when not used are just pointless.
This file is auto-generated to provide a complete set of RMIO 
configurations.   Our intention is to offer a generic library for all 
future board developers, so they can simply pick the needed nodes by 
phandle without manually looking up register values in the datasheet 
every time.   This improves usability and standardization.

We also used the /omit-if-no-ref/ tag, so this will strictly not 
increase the size of the compiled DTB binary at all.

Could you please reconsider if this  approach is acceptable given the 
usability benefits?

If you still consider the ~25k lines of source code bloat unacceptable 
for upstream, we will have to drop this generic dtsi file and let users 
manually define only the required nodes when adding board support.

Best regards,
Ye Zhang