Re: [PATCH v4 3/7] dt-bindings: leds: Add virtual LED group controller bindings

From: Krzysztof Kozlowski

Date: Wed Dec 31 2025 - 03:03:26 EST


On 30/12/2025 09:32, Jonathan Brophy wrote:
>> My bot found errors running 'make dt_binding_check' on your patch:
>
>> yamllint warnings/errors:
>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.example.dtb: pwm-led-controller (pwm->leds): 'led-pwm-blue', 'led-pwm-green', 'led-pwm-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', '^pinctrl-[0-9]+$'
>
>
> Thanks I have fixed this and re submitted a v5 patch series.
>
> I have been testing on OpenWrt where the yaml and dts files are not validated and this slipped in.
>


You must base and test on mainline, not OpenWRT. I understand above that
v5 wasn't tested either, so I won't be reviewing it.

Best regards,
Krzysztof