Re: [PATCH v2] mm/memblock: drop redundant 'struct page *' argument from memblock_free_pages()

[David Hildenbrand (Red Hat)]

On 12/29/25 14:52, shengminghu512 wrote:
> From: Shengming Hu <hu.shengming@xxxxxxxxxx>
>
> memblock_free_pages() currently takes both a struct page * and the
> corresponding PFN. The page pointer is always derived from the PFN at
> call sites (pfn_to_page(pfn)), making the parameter redundant and also
> allowing accidental mismatches between the two arguments.
>
> Simplify the interface by removing the struct page * argument and
> deriving the page locally from the PFN, after the deferred struct page
> initialization check. This keeps the behavior unchanged while making
> the helper harder to misuse.
>
> Signed-off-by: Shengming Hu <hu.shengming@xxxxxxxxxx>
> ---

Reviewed-by: David Hildenbrand (Red Hat) <david@xxxxxxxxxx>

--
Cheers

David