Re: [PATCH v1 2/4] wifi: rsi: sdio: Reduce use of #ifdef for CONFIG_PM
From: Uwe Kleine-König
Date: Tue Dec 30 2025 - 13:57:03 EST
On Mon, Dec 29, 2025 at 11:36:02AM +0100, Johannes Berg wrote:
> On Wed, 2025-12-17 at 12:09 +0100, Uwe Kleine-König wrote:
> > This drops two #ifdefs (which is good because they are ugly) without
> > changing semantics. This also improves compile coverage because all the
> > code in the first #ifdef block is now compiled even for configurations
> > without CONFIG_PM (and then thrown away).
>
> This didn't build, and given that we never got 1/4 I'm going to assume
> it wasn't destined to the wireless tree.
Yes, this depends on patch #1, I expected the series to go in via
whatever tree sdio usually goes in and didn't notice that all users are
in the wireless subsystem.
The kernel robot also found an issue[1] that needs addressing (probably
by dropping patch #2 from the series). Will look into that next year.
Best regards
Uwe
[1] https://lore.kernel.org/all/202512210032.6Skz9prt-lkp@xxxxxxxxx/
Attachment:
signature.asc
Description: PGP signature