Re: [PATCH v3 3/4] fbdev: omapfb: Make FB_DEVICE dependency optional
From: Chintan Patel
Date: Tue Dec 30 2025 - 13:01:48 EST
On 12/30/25 03:37, Andy Shevchenko wrote:
On Mon, Dec 29, 2025 at 09:28:21PM -0800, Chintan Patel wrote:Sorry about that. I had actually made your suggested changes but somehow I mistakenly send old patches instead of updated one. I will send updated one. Should I send v4 or v3 is fine?
omapfb provides several sysfs interfaces for framebuffer configuration
and debugging, but these are not required for the core driver.
Remove the hard dependency on CONFIG_FB_DEVICE and make sysfs support
optional by using dev_of_fbinfo() to obtain the backing device at runtime.
When FB_DEVICE is disabled, sysfs operations are skipped while the code
still builds and is type-checked.
...
+ struct device *dev = dev_of_fbinfo(fbdev->fbs[i]);
Still the same issue I pointed out in v2 review.
int t;
+
+ if (!dev)
+ continue;
...
+ struct device *dev = dev_of_fbinfo(fbdev->fbs[i]);
+
+ if (!dev)
+ continue;
Ditto.