Re: [PATCH net] net: wwan: iosm: Fix memory leak in ipc_mux_deinit()

From: Zilin Guan

Date: Tue Dec 30 2025 - 04:25:37 EST


On Tue, Dec 30, 2025 at 10:15:05AM+0100, Markus Elfring wrote:
>
> > +++ b/drivers/net/wwan/iosm/iosm_ipc_mux.c
> > @@ -456,6 +456,7 @@ void ipc_mux_deinit(struct iosm_mux *ipc_mux)
> > struct sk_buff_head *free_list;
> > union mux_msg mux_msg;
> > struct sk_buff *skb;
> > + int i;
>
>
> May this variable be defined in the loop header instead?
>
> Regards,
> Markus

Thanks for the suggestion.

I would prefer to keep the declaration at the top of the block to maintain
consistency with the existing coding style of this function and to keep
the patch focused strictly on the fix.

Regards,
Zilin Guan