Re: [PATCH 3/9] sysctl: Generate do_proc_doulongvec_minmax with do_proc_dotypevec macro

[Joel Granados]

On Mon, Dec 29, 2025 at 03:17:58PM +0800, kernel test robot wrote:
> 
> 
> Hello,
> 
> kernel test robot noticed "blktests.block/020.fail" on:
> 
> commit: 216729bf72d98eca7a48326bb17b577c3fde9634 ("[PATCH 3/9] sysctl: Generate do_proc_doulongvec_minmax with do_proc_dotypevec macro")
> url: https://github.com/intel-lab-lkp/linux/commits/Joel-Granados/sysctl-Move-default-converter-assignment-out-of-do_proc_dointvec/20251219-202253
> patch link: https://lore.kernel.org/all/20251219-jag-dovec_consolidate-v1-3-1413b92c6040@xxxxxxxxxx/
> patch subject: [PATCH 3/9] sysctl: Generate do_proc_doulongvec_minmax with do_proc_dotypevec macro
> 
> in testcase: blktests
> version: blktests-x86_64-b1b99d1-1_20251223
> with following parameters:
> 
> 	disk: 1HDD
> 	test: block-020
> 
> 
> 
> config: x86_64-rhel-9.4-func
> compiler: gcc-14
> test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (Skylake) with 32G memory
> 
> (please refer to attached dmesg/kmsg for entire log/backtrace)
> 
> 
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <oliver.sang@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-lkp/202512291555.395cc7b0-lkp@xxxxxxxxx
> 
> 2025-12-26 15:49:33 cd /lkp/benchmarks/blktests
> 2025-12-26 15:49:33 echo block/020
> 2025-12-26 15:49:33 ./check block/020
> block/020 (run null-blk on different schedulers with only one hardware tag)
> block/020 (run null-blk on different schedulers with only one hardware tag) [failed]
>     runtime    ...  42.071s
>     --- tests/block/020.out	2025-12-23 16:47:43.000000000 +0000
>     +++ /lkp/benchmarks/blktests/results/nodev/block/020.out.bad	2025-12-26 15:50:16.434082831 +0000
>     @@ -1,2 +1,10 @@
>      Running block/020
>     +iodepth: min value out of range: -16384 (1 min)
>     +_fio_perf: too many terse lines
>     +iodepth: min value out of range: -16384 (1 min)
>     +_fio_perf: too many terse lines
>     +iodepth: min value out of range: -16384 (1 min)
>     +_fio_perf: too many terse lines
>     ...
>     (Run 'diff -u tests/block/020.out /lkp/benchmarks/blktests/results/nodev/block/020.out.bad' to see the entire diff)

This is because the value returned after reading the ulong value in
/proc/sys/fs/aio-max-nr was negative (which should not happen). This is
a particular behavior for this .config that I did not encounter in my
tests.

I have reproduced it and corrected it in V2.

Best

-- 

Joel Granados

Attachment: signature.asc
Description: PGP signature