Re: [PATCH v3 3/9] remoteproc: qcom_q6v5_mss: Add MDM9607
From: Bryan O'Donoghue
Date: Thu Jan 01 2026 - 08:23:42 EST
On 01/01/2026 13:19, Bryan O'Donoghue wrote:
In the first case you care that the bit indicates something useful, in
the second case it barely indicates anything at all.
Swap these bits, the first case is an acknowledgement of receiving a
command the second case is a status bit from carrying out the command.
Either way it seems a bit mindless to just or back in whatever bit you
read back here... in fact shouldn't val be _equal_ to the value -
instead of or-ing the value in ?
I think it probably should and I also think if you are error checking
you should check your flagged bit actually appears in the read-back dword.
---
bod