[PATCH] gpu: nova-core: use stable name() method in Chipset Display impl
From: Maurice Hieronymus
Date: Thu Jan 01 2026 - 13:42:01 EST
Chipset's Display was using Debug formatting ("{self:?}"), which is not
guaranteed to be stable. Use the existing name() method instead, which
provides stable lowercase strings suitable for firmware path generation.
Signed-off-by: Maurice Hieronymus <mhi@xxxxxxxxxxx>
---
drivers/gpu/nova-core/gpu.rs | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs
index 629c9d2dc994..be8c882338ea 100644
--- a/drivers/gpu/nova-core/gpu.rs
+++ b/drivers/gpu/nova-core/gpu.rs
@@ -107,17 +107,9 @@ pub(crate) fn arch(&self) -> Architecture {
}
}
-// TODO
-//
-// The resulting strings are used to generate firmware paths, hence the
-// generated strings have to be stable.
-//
-// Hence, replace with something like strum_macros derive(Display).
-//
-// For now, redirect to fmt::Debug for convenience.
impl fmt::Display for Chipset {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
- write!(f, "{self:?}")
+ write!(f, "{}", self.name())
}
}
base-commit: b69053dd3ffbc0d2dedbbc86182cdef6f641fe1b
--
2.51.2