Re: [PATCH v7 2/2] media: i2c: add os05b10 image sensor driver

[sakari.ailus@xxxxxxxxxxxxxxx]

Hi Himanshu,

On Thu, Jan 01, 2026 at 06:19:02AM +0000, Himanshu Bhavani wrote:
> >> +#define OS05B10_PIXEL_RATE           (480 * HZ_PER_MHZ)
> >
> >Here pixel rate should not be hardcoded, it'd be computed in runtime
> >as 600MHz * 2 * 4 lanes / 10 bpp = 480MHz.
> >
> >The sensor may be wired over 2 lanes or (presumably) it can stream 8 bpp data.
> 
> We are not supporting 2 lanes right now, driver supports only for 4 lanes and 
> 10 bpp data. So technically OS05B10_PIXEL_RATE will never change.
> For reference I will add OS05B10_PIXEL_RATE calculation in comments.
> I would prefer the hardcoded at the moment. Other than this comment 
> I will resolve and send new version.

The pixel rate on the pixel array may be disconnected from the link
frequency (and throughput) -- it may be more (with e.g. binning) or less,
depending on the sensor of course. Calculating it, if possible, is always
better than using a fixed value; experience has shown these are often
simply incorrect and sometimes not updated when other changes are made (and
same goes for the link frequency).

-- 
Kind regards,

Sakari Ailus