Re: [PATCH v2 0/3] pinctrl: spacemit: add support for K3 SoC

[Linus Walleij]

Hi Yixun,

thanks for your patches!

On Fri, Dec 26, 2025 at 1:58 PM Yixun Lan <dlan@xxxxxxxxxx> wrote:

> This series attempt to add pinctrl support for SpacemiT K3 SoC,
>
> I've removed the RFC tag as the driver is tested on K3 SoC.
>
> The K3 pinctrl IP shares almost same logic with previous K1 SoC generation,
> but has different register offset and pin configuration, I've introduced
> a pin_to_offset() function to handle the difference of register offset.
> for the drive strength and schmitter trigger settings, they are also changed.
>
> The patch #1 try to add pin support which should handle pin mux, while patch #2
> adjust drive strength and schmitter trigger settings accordingly for new SoC.
>
> Signed-off-by: Yixun Lan <dlan@xxxxxxxxxx>

As Krzysztof mentioned, try to use an explicit device tree schema to
enforce the legal drive strength values as e.g. enums.

Other than this the code looks fine so once the bindings are
ACK:ed I'm ready to merge this.

Yours,
Linus Walleij