Re: [PATCH 2/2] pinctrl: spacemit: support I/O power domain configuration

[Linus Walleij]

Hi Troy,

thanks for your patch!

On Tue, Dec 23, 2025 at 10:43 AM Troy Mitchell
<troy.mitchell@xxxxxxxxxxxxxxxxxx> wrote:

> > > +   pctrl->io_pd_reg = devm_platform_ioremap_resource(pdev, 1);
> > > +   if (IS_ERR(pctrl->io_pd_reg))
> > > +           return PTR_ERR(pctrl->io_pd_reg);
> > > +
> > > +   pctrl->regmap_apbc =
> > > +           syscon_regmap_lookup_by_phandle_args(np, "spacemit,apbc", 1,
> > > +                                                &pctrl->regmap_apbc_offset);
> > Can you simply use syscon_regmap_lookup_by_phandle(), then define
> > #define APBC_ASFAR            0x50
> > #define APBC_ASSAR            0x54

> I think it just a minor issue. I will keep it.
> But if anyone else thinks the same way as Yixun, please let me know.

It's not minor because it adds stuff to the DT binding we don't need
and this avoids it.

Please go with Yixun's suggestion.

Yours,
Linus Walleij