Re: [PATCH 2/2] arm64: dts: qcom: purwa: Drop the Hamoa workaround for PDC

[Maulik Shah (mkshah)]

On 12/31/2025 5:24 PM, Konrad Dybcio wrote:
> On 12/31/25 11:18 AM, Maulik Shah wrote:
>> Purwa shares the Hamoa (X1E80100) PDC device, but the hardware register
>> bug addressed in commit e9a48ea4d90b ("irqchip/qcom-pdc: Workaround
>> hardware register bug on X1E80100") is already fixed in Purwa silicon.
>>
>> Hamoa compatible forces the software workaround. Use the Purwa specific
>> compatible string for the PDC node to remove the workaround from Purwa.
>>
>> Fixes: f08edb529916 ("arm64: dts: qcom: Add X1P42100 SoC and CRD")
>> Signed-off-by: Maulik Shah <maulik.shah@xxxxxxxxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/purwa.dtsi | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/purwa.dtsi b/arch/arm64/boot/dts/qcom/purwa.dtsi
>> index 2cecd2dd0de8c39f0702d6983bead2bc2adccf9b..e3e2dfedf0b3cad90b767d6b28fb0c60078d192b 100644
>> --- a/arch/arm64/boot/dts/qcom/purwa.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/purwa.dtsi
>> @@ -152,6 +152,10 @@ &pcie6a_phy {
>>  	compatible = "qcom,x1p42100-qmp-gen4x4-pcie-phy";
>>  };
>>  
>> +&pdc {
>> +	compatible = "qcom,x1p42100-pdc", "qcom,pdc";
> 
> I think it would make sense to add a comment above the compatible line,
> saying that the PDC is largely the same as the bigger brother's, sans
> the bug
> 

Sure, Will comment in v2 above the compatible line.

Thanks,
Maulik