Re: [PATCH v6 1/2] platform/x86: thinkpad_acpi: Add support to detect hardware damage detection capability.

[Nitin]

On 12/30/25 01:49, Ilpo Järvinen wrote:
> On Wed, 24 Dec 2025, Nitin Joshi wrote:
>
> > Thinkpads are adding the ability to detect and report hardware damage
> > status. Add new sysfs interface to identify whether hardware damage
> > is detected or not.
> >
> > Initial support is available for the USB-C replaceable connector.
> >
> > Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
> > Signed-off-by: Nitin Joshi<nitjoshi@xxxxxxxxx>
> > ---
> > Changes since v1:
> > -Split patch between hwdd_status and hwdd_detail
> > -Incorporated review comments
> > Changes since v2:
> > -Control visibility of the sysfs attribute based upon ucdd_supported
> > Changes since v3:
> > -Fix documentation build warning
> > Changes since v4:
> > -Removed extra line
> > Changes since v5:
> > -Improved code indentation
> > ---
> >   .../admin-guide/laptops/thinkpad-acpi.rst     |  21 ++++
> >   drivers/platform/x86/lenovo/thinkpad_acpi.c   | 105 ++++++++++++++++++
> >   2 files changed, 126 insertions(+)
> >
> > diff --git a/Documentation/admin-guide/laptops/thinkpad-acpi.rst b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
> > index 4ab0fef7d440..2db05f718b11 100644
> > --- a/Documentation/admin-guide/laptops/thinkpad-acpi.rst
> > +++ b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
> > @@ -54,6 +54,7 @@ detailed description):
> >   	- Setting keyboard language
> >   	- WWAN Antenna type
> >   	- Auxmac
> > +	- Hardware damage detection capability
> >   
> >   A compatibility table by model and feature is maintained on the web
> >   site, http://ibm-acpi.sf.net/. I appreciate any success or failure
> > @@ -1576,6 +1577,26 @@ percentage level, above which charging will stop.
> >   The exact semantics of the attributes may be found in
> >   Documentation/ABI/testing/sysfs-class-power.
> >   
> > +Hardware damage detection capability
> > +------------------------------------
> > +
> > +sysfs attributes: hwdd_status
> > +
> > +Thinkpads are adding the ability to detect and report hardware damage.
> > +Add new sysfs interface to identify the damaged device status.
> > +Initial support is available for the USB-C replaceable connector.
> > +
> > +The command to check device damaged status is::
> > +
> > +        cat /sys/devices/platform/thinkpad_acpi/hwdd_status
> > +
> > +This value displays status of device damaged
> > +- 0 = Not Damaged
> > +- 1 = Damaged
> This seems to result in not the best formatting for htmldocs:
>
> "This value displays status of device damaged - 0 = Not Damaged - 1 = Damaged"

Ack. I will modify it and send updated patch for this. I will also 
modify slightly for Patch 2/2 as well.

 Happy New Year !

Best Regards,

Nitin Joshi