Re: [PATCH 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc

[Matti Vaittinen]

On 31/12/2025 19:12, Jonathan Cameron wrote:
> On Mon, 29 Dec 2025 10:20:23 +0200
> Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:
>
> > On 23/12/2025 17:55, Maxime Chevallier wrote:
> > > This adds a new driver for the TI TLA2528 ADC chip. It ha 8 12-bit
> > > channels, that can also be configured as 16-bit averaging channels.
> > >
> > > Add a very simple driver for it, allowing reading raw values for each
> > > channel.
> > >
> > > Signed-off-by: Rodolfo Giometti <giometti@xxxxxxxxxxxx>
> > > Signed-off-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
> > > ---
> > >    MAINTAINERS                  |   7 ++
> > >    drivers/iio/adc/Kconfig      |  10 ++
> > >    drivers/iio/adc/Makefile     |   1 +
> > >    drivers/iio/adc/ti-tla2528.c | 209 +++++++++++++++++++++++++++++++++++
> > >    4 files changed, 227 insertions(+)
> > >    create mode 100644 drivers/iio/adc/ti-tla2528.c
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index dc731d37c8fe..5c382ae216c7 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -25866,6 +25866,13 @@ F:	include/dt-bindings/soc/ti,sci_pm_domain.h
> > >    F:	include/linux/soc/ti/ti_sci_inta_msi.h
> > >    F:	include/linux/soc/ti/ti_sci_protocol.h
> > >    
> > > +TEXAS INSTRUMENTS' TLA2528 ADC DRIVER
> > > +M:	Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
> > > +L:	linux-iio@xxxxxxxxxxxxxxx
> > > +S:	Supported
> > > +F:	Documentation/devicetree/bindings/iio/adc/ti,tla2528.yaml
> > > +F:	drivers/iio/adc/ti-tla2528.c
> > > +
> > >    TEXAS INSTRUMENTS' TMP117 TEMPERATURE SENSOR DRIVER
> > >    M:	Puranjay Mohan <puranjay@xxxxxxxxxx>
> > >    L:	linux-iio@xxxxxxxxxxxxxxx
> > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > > index 58da8255525e..67376de410bf 100644
> >
> > Hmm. Would it ease merging if MAINTAINERS changes were in their own patch?
>
> Not particularly.  Though I personally slightly prefer the logic
> of bringing the entry in with the first file, then adding additional files
> in later patches.
>
> Given it is huge and in alphabetical order, conflicts in MAINTAINERS are
> fairly rare and trivial to resolve.

Thanks for this clarification :)

I don't know where I had picked up this idea, but I thought that the 
volume of changes in MAINTAINERs was somewhat annoying source of 
conflicts. I sit and type corrected :)


Yours,
	-- Matti

---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~