Re: [PATCH v2 1/8] dt-bindings: clk: mstar msc313 cpupll: Correct clock-cells value

[Krzysztof Kozlowski]

On Thu, Jan 01, 2026 at 12:42:59PM +0900, Daniel Palmer wrote:
> clock-cells should have been 0 and causes warnings when

Why it should have been 0? That's what your commit msg should explain.


> validating devicetrees.
> 
> Fix the value and fix the binding example.
> 
> Signed-off-by: Daniel Palmer <daniel@xxxxxxxx>
> ---
>  .../devicetree/bindings/clock/mstar,msc313-cpupll.yaml       | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.yaml b/Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.yaml
> index a9ad7ab5230c..889419fba269 100644
> --- a/Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.yaml
> +++ b/Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.yaml
> @@ -18,7 +18,7 @@ properties:
>      const: mstar,msc313-cpupll
>  
>    "#clock-cells":
> -    const: 1
> +    const: 0

That's technically ABI break and your commit msg must explain also the
impact of that break.

Best regards,
Krzysztof