Re: [PATCH 1/2] dt-bindings: pinctrl: Add Mahua TLMM support

[Krzysztof Kozlowski]

On 02/01/2026 12:07, Gopikrishna Garmidi wrote:
> Update the compatible property to accept both "qcom,glymur-tlmm" and
> "qcom,mahua-tlmm" using enum to allow proper device tree validation
> for both SoCs.

1. Why? You explained what, with a lot of redundant words. I do not find
"paid by commit line" useful. Drop all the redundancies, do not explain
what is "device tree validation". Look at other commits to learn how
this is supposed to be written.

2. Why they are not compatible? You have entire commit msg to say
something useful instead stating obvious and repeating the diff.

3. Subject: You cannot add "support" in the binding. Again, look at
other commits.


Best regards,
Krzysztof