Re: [PATCH v2 1/4] dt-bindings: can: renesas,rcar-canfd: Specify reset-names

[Krzysztof Kozlowski]

On Tue, Dec 30, 2025 at 11:58:11AM +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> 
> Specify the expected reset-names for the Renesas CAN-FD controller on
> RZ/G2L and RZ/G3E SoCs.

You should explain here from where you got the actual names.

Otherwise you got following review:

> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> v1->v2:
> - Moved reset-names to top-level properties.
> ---
>  .../bindings/net/can/renesas,rcar-canfd.yaml  | 33 +++++++++++--------
>  1 file changed, 19 insertions(+), 14 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index e129bdceef84..9bfd4f44e4d4 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> @@ -122,6 +122,11 @@ properties:
>  
>    resets: true
>  
> +  reset-names:
> +    items:
> +      - const: rstp_n
> +      - const: rstc_n

rst seems redundant. _n as well. Are these names from datasheet? How are
they called in this device (not the soc) datasheet exactly? Because it
feels you use pin or SoC names which is not useful.

Best regards,
Krzysztof